[
https://issues.apache.org/jira/browse/CB-11598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382746#comment-15382746
]
ASF GitHub Bot commented on CB-11598:
-------------------------------------
GitHub user Jak12132 opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/188
CB-11598: (iOS) Fix iOS base64 output having newline chars
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
Makes the base64 output omit newline chars. This makes it consistent with
the Android implementation and allows the base64 output to inputted into an
NSData initWithBase64EncodedString: without any workarounds.
### What testing has been done on this change?
Output data has been used to generate object URLs for images on a page and
to send to Instagram using the cordova-instagram-plugin (Which simply takes the
data and uses it to write an image file).
### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and
submitted to [email protected].
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jak12132/cordova-plugin-file patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/188.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #188
----
commit d1e78920211b6cb3fe4f2daf241fc7bea5f3fe56
Author: Jak12132 <[email protected]>
Date: 2016-07-18T16:10:53Z
No longer add /r/n to the base64 output
This makes it consistent with the Android implementation and allows the
base64 output to inputted into an NSData initWithBase64EncodedString: without
any workarounds.
----
> iOS base64 output has newline chars
> -----------------------------------
>
> Key: CB-11598
> URL: https://issues.apache.org/jira/browse/CB-11598
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
> Environment: iOS
> Reporter: Austin Conatser
> Priority: Trivial
> Labels: easyfix
>
> NSData+Base64 code requires the selector to explicitly not use separate lines
> by using @"base64EncodedStringWithSeparateLines:false" instead of
> @"base64EncodedString" at CDVFile.m:28. This would make it consistent with
> the Android implementation and allows the base64 data (without string
> replacement workarounds) to be used with NSData initWithBase64EncodedString:.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
