[
https://issues.apache.org/jira/browse/CB-11548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388473#comment-15388473
]
ASF GitHub Bot commented on CB-11548:
-------------------------------------
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/188#discussion_r71791061
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -93,6 +93,20 @@ module.exports.findAllAvailableVersions = function () {
return !!item;
});
});
+}
+
+module.exports.findAllAvailableVersions = function () {
+ // CB-11548 use VSINSTALLDIR environment if defined to find MSBuild.
If VSINSTALLDIR
+ // is not specified or incorrect - fall back to default discovery
mechanism.
--- End diff --
It is quite likely that `VSINSTALLDIR` is specified and *correct*, but just
doesn't contain the msbuild path we're looking for (this will be the case for
previous versions of VS, for example). So I think it would be clearer to say
here something like "not specified or doesn't contain the MSBuild path we are
looking for".
> Cordova-windows should allow to use specific version of msbuild
> ---------------------------------------------------------------
>
> Key: CB-11548
> URL: https://issues.apache.org/jira/browse/CB-11548
> Project: Apache Cordova
> Issue Type: New Feature
> Components: Windows
> Affects Versions: 4.4.0
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
> Labels: build, windows
> Fix For: 4.4.1
>
>
> Currently cordova-windows uses own logic to determine and find required
> version of msbuild to build the project. However there might be some
> situations when user might want to specify, which msbuild version should be
> used
> The idea is to check {{VSINSTALLDIR}} environment variable before building
> the project and if it is defined - use it to find required msbuild executable
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
