[ 
https://issues.apache.org/jira/browse/CB-10142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390407#comment-15390407
 ] 

ASF GitHub Bot commented on CB-10142:
-------------------------------------

GitHub user cjpearson opened a pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/12

    CB-10142: Allow opening WebSQL databases in WKWebView

    <!--
    Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist
    is intended as a quick reference, for complete details please see our 
Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    iOS
    
    ### What does this PR do?
    
    Allows WebSql databases to be opened when using this plugin. Right now it 
gives databases a quota of 50MB.
    
    ### What testing has been done on this change?
    
    Tested on iOS 9 iPhone simulator and iPad. 
    
    ### Checklist
    - [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to [email protected].
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cjpearson/cordova-plugin-wkwebview-engine 
CB-10142

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12
    
----
commit 7856a61866971cd2c9eb5340c65891abea70c315
Author: Connor Pearson <[email protected]>
Date:   2016-07-23T00:16:00Z

    CB-10142: Allow opening WebSQL databases in WKWebView

----


> WebSQL (window.openDatabase) will not work in WKWebViewEngine
> -------------------------------------------------------------
>
>                 Key: CB-10142
>                 URL: https://issues.apache.org/jira/browse/CB-10142
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin WKWebViewEngine
>            Reporter: Shazron Abdullah
>              Labels: wkwebview-known-issues
>
> It fails mobile-spec storage.spec.18 and is a known WKWebView bug (not fixed 
> as of iOS 9.1): https://bugs.webkit.org/show_bug.cgi?id=137760
> The test is skipped when you run the engine on mobile-spec.
> window.openDatabase is defined, but throws an error when you use it.
> This is an Apple bug.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to