[
https://issues.apache.org/jira/browse/CB-8947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398049#comment-15398049
]
ASF GitHub Bot commented on CB-8947:
------------------------------------
GitHub user don opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/80
CB-8947: (ios)
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
Fix crash when non-strings are passed to dialogs
### What testing has been done on this change?
Added manual tests to plugin
https://github.com/don/cordova-plugin-dialogs/blob/CB-8947/tests/tests.js#L206-L224
### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and
submitted to [email protected].
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/don/cordova-plugin-dialogs CB-8947
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-dialogs/pull/80.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #80
----
----
> alert() crashes when passing a JSON object on iOS
> -------------------------------------------------
>
> Key: CB-8947
> URL: https://issues.apache.org/jira/browse/CB-8947
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Dialogs
> Affects Versions: 4.0.0
> Environment: Notifications Plugin version 0.3.0
> Reporter: Dennis Patzer
> Priority: Minor
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> In the error handler of a geolocation retrieval I had alert(error); which
> crashes, because I passed an object into the function call. This shouldn't
> happen.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
