[
https://issues.apache.org/jira/browse/CB-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398067#comment-15398067
]
ASF GitHub Bot commented on CB-8320:
------------------------------------
Github user dpogue commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/469#discussion_r72685014
--- Diff: cordova-lib/src/cordova/metadata/android_parser.js ---
@@ -31,14 +31,20 @@ var fs = require('fs'),
function android_parser(project) {
- if (!fs.existsSync(path.join(project, 'AndroidManifest.xml'))) {
+ if (!fs.existsSync(path.join(project, 'build.gradle'))) {
throw new CordovaError('The provided path "' + project + '" is not
an Android project.');
}
// Call the base class constructor
Parser.call(this, 'android', project);
this.path = project;
+
+ //If we have a gradle file but not a manifest, this is an Android
Studio project
+ if(!fs.existsSync(path.join(project, "AndroidManifest.xml"))) {
--- End diff --
@infil00p Apparently this fails the jslint step because of double quotes
here, which is why the Travis and Appveyor builds failed. It wants all JS
strings to use single quotes.
> Support using cordova with standard Android projects
> ----------------------------------------------------
>
> Key: CB-8320
> URL: https://issues.apache.org/jira/browse/CB-8320
> Project: Apache Cordova
> Issue Type: New Feature
> Components: Android
> Reporter: Graham Mueller
> Assignee: Joe Bowser
> Labels: gradle, plugins
> Fix For: 5.0.0
>
>
> We've recently started to use the newer project structure recommended for the
> [Android
> Tools|http://tools.android.com/tech-docs/new-build-system/user-guide#TOC-Configuring-the-Structure].
> The basic idea is
> {code}
> /platforms/android
> /build.gradle
> /settings.gradle
> /etc...
> /cordova
> /CordovaLib
> /APP_NAME
> /build.gradle
> /src
> /main
> /assets
> /res
> /java
> /...
> {code}
> When you try to run {{cordova plugin add ...}}, it assumes you have the
> assets, res, and src at the root of the Android directory. Is there any way
> to change this expectation, since the newer projects are kind of expected to
> be this way? I acknowledge that the Android cmd line tool doesn't do this
> yet, but you can't expect Google to keep up with their own tools.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
