[
https://issues.apache.org/jira/browse/CB-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399345#comment-15399345
]
ASF GitHub Bot commented on CB-11205:
-------------------------------------
GitHub user matrosovN opened a pull request:
https://github.com/apache/cordova-lib/pull/471
CB-11205 fix bug restore plugin with variables via 'plugin add' command
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosovN/cordova-lib master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/471.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #471
----
commit d458c14e93d7be3aa85d871c23d4419456ef1b70
Author: Nikita Matrosov <[email protected]>
Date: 2016-07-29T11:47:44Z
CB-11205 fix bug restore plugin with variables via 'plugin add' command
----
> Plugin Add does not respect variables saved in config.xml
> ---------------------------------------------------------
>
> Key: CB-11205
> URL: https://issues.apache.org/jira/browse/CB-11205
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Reporter: Richard B Knoll
> Priority: Minor
> Labels: triaged
>
> If a plugin with CLI variables is saved using {{--save}}, the variables will
> be saved into config.xml along with the plugin spec like so:
> {code}
> <plugin name="my-plugin" spec="1.2.0" >
> <variable name="MY_VARIABLE" value ="my_variable_value" />
> </plugin>
> {code}
> Which corresponds to
> {code}
> cordova plugin add [email protected] --variable MY_VARIABLE=my_variable_value
> --save
> {code}
> Cordova prepare will restore the plugin using the saved plugin spec and
> variable values. Plugin add will used the saved spec, but not the saved
> variable values. Plugin add should behave the same way as prepare.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
