[
https://issues.apache.org/jira/browse/CB-11645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400299#comment-15400299
]
ASF GitHub Bot commented on CB-11645:
-------------------------------------
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-lib/pull/473
CB-11645 added check to see if getEditConfig exists before trying to …
…use it
Please review @macdonst @vladimir-kotikov @ktop. I am not familiar enough
with these new changes. Does more need to be done?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-lib CB-11645
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/473.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #473
----
commit 63f3af4280e2da1ecedf8df25f1bb1a1230409c1
Author: Steve Gill <stevengil...@gmail.com>
Date: 2016-07-30T00:16:02Z
CB-11645 added check to see if getEditConfig exists before trying to use it
----
> cordova-android@5.2.2 doesn't install plugins on <= cordova@6.3.0
> -----------------------------------------------------------------
>
> Key: CB-11645
> URL: https://issues.apache.org/jira/browse/CB-11645
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaCommon
> Reporter: Steve Gill
>
> Trying to add cordova-android@5.2.2 or master using cordova@6.2.0 will give
> the following error when installing the whitelist plugin
> `Failed to install 'cordova-plugin-whitelist':TypeError:
> pluginInfo.getEditConfigs is not a function
> at PlatformMunger.add_plugin_changes
> (/Users/steveng/repo/cordova/tests/myapp/platforms/android/cordova/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:134:42)
> at
> /Users/steveng/repo/cordova/tests/myapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:126:25
> at _fulfilled
> (/Users/steveng/repo/cordova/tests/myapp/platforms/android/cordova/node_modules/q/q.js:834:54)
> at self.promiseDispatch.done
> (/Users/steveng/repo/cordova/tests/myapp/platforms/android/cordova/node_modules/q/q.js:863:30)
> at Promise.promise.promiseDispatch
> (/Users/steveng/repo/cordova/tests/myapp/platforms/android/cordova/node_modules/q/q.js:796:13)
> at
> /Users/steveng/repo/cordova/tests/myapp/platforms/android/cordova/node_modules/q/q.js:857:14
> at runSingle
> (/Users/steveng/repo/cordova/tests/myapp/platforms/android/cordova/node_modules/q/q.js:137:13)
> at flush
> (/Users/steveng/repo/cordova/tests/myapp/platforms/android/cordova/node_modules/q/q.js:125:13)
> at _combinedTickCallback (internal/process/next_tick.js:67:7)
> at process._tickCallback (internal/process/next_tick.js:98:9)
> Failed to restore plugin "cordova-plugin-whitelist" from config.xml. You
> might need to try adding it again. Error: TypeError:
> pluginInfo.getEditConfigs is not a function```
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
