[
https://issues.apache.org/jira/browse/CB-11410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401188#comment-15401188
]
ASF GitHub Bot commented on CB-11410:
-------------------------------------
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/224
CB-11410: (ios) fix cameraPopoverHandle.setPosition
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
fix cameraPopoverHandle.setPosition
You have to dismiss the existing popover before presenting it on a new
possition or it won't work
### What testing has been done on this change?
Tested on iOS 8 and iOS 9 iPads
### Checklist
- [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and
submitted to [email protected].
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcesarmobile/cordova-plugin-camera CB-11410
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/224.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #224
----
commit 9677a8056ed498f1eca1e2eae7e522373d8703aa
Author: Julio César <[email protected]>
Date: 2016-07-31T15:13:57Z
CB-11410: (ios) fix cameraPopoverHandle.setPosition
----
> navigator.camera.getPicture returns undefined instead of CameraPopoverHandle
> object
> -----------------------------------------------------------------------------------
>
> Key: CB-11410
> URL: https://issues.apache.org/jira/browse/CB-11410
> Project: Apache Cordova
> Issue Type: Bug
> Components: Docs, Plugin Camera
> Affects Versions: Master
> Environment: iOS
> Reporter: Yazeed Fares
> Assignee: jcesarmobile
> Priority: Critical
>
> The camera plugin documentation describes that you can control the camera
> popover when device orientation changes, I tried the example but is is not
> working, so I went to the code to see what is happening and noticed that the
> navigator.camera.getPicture function doesn't return anything because the
> lines that returns the CameraPopoverHandle object are commented out.
> So I uncommented them to test but the issue is still happening, there is
> something wrong in the native code.
> My test was on real iPad iOS 9.3.2 and on iOS simulator with iOS 8.4
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
