[
https://issues.apache.org/jira/browse/CB-11558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403601#comment-15403601
]
ASF GitHub Bot commented on CB-11558:
-------------------------------------
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/185#discussion_r73113256
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -105,7 +105,7 @@ var handlers = {
var type = obj.type;
if(type === 'projectReference') {
- project.removeProjectReference(path.join(plugin.dir, src),
getTargetConditions(obj));
+ project.removeProjectReference(path.join('..', '..',
'plugins', plugin.id, src), getTargetConditions(obj));
--- End diff --
Updated, thanks for review!
There was an issue with mock dummyplugin, which PluginInfo.dir was
initialized with a corresponding fixture path - so in case when the temp folder
was on a different drive it caused path.relative to resolve in an absolute path
in
[PluginHandler.framework.install](https://github.com/daserge/cordova-windows/blob/2bc5d96bdd0f6c9328680bede1b535dde218e23c/template/cordova/lib/PluginHandler.js#L91).
Normally we have a plugin.dir path initialized with relative path to the
project root, i.e. `project_root/plugins/plugin-id` - so I've updated the tests
accordingly.
I've also tested that install/rm a plugin from another drive updates jsproj
files properly.
> Make windows plugin rm remove ProjectReference items
> ----------------------------------------------------
>
> Key: CB-11558
> URL: https://issues.apache.org/jira/browse/CB-11558
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Affects Versions: 4.4.2
> Reporter: Sergey Shakhnazarov
> Assignee: Sergey Shakhnazarov
> Labels: triaged, windows
> Fix For: 4.4.3
>
>
> {{cordova plugin add phonegap-plugin-barcodescanner}}
> CordovaApp.Windows.jsproj ->
> {noformat}
> <ItemGroup>
> <ProjectReference
> Include="..\..\plugins\phonegap-plugin-barcodescanner\src\windows\lib\WinRTBarcodeReader.csproj"
> />
> </ItemGroup>
> {noformat}
> {{cordova plugin rm phonegap-plugin-barcodescanner}}
> {{ItemGroup}} not being removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
