[
https://issues.apache.org/jira/browse/CB-11074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410014#comment-15410014
]
ASF GitHub Bot commented on CB-11074:
-------------------------------------
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/13
CB-11074 - Ensure settings from config.xml are taken into consideration
Take note of the disabled "testConfigurationWithMediaPlaybackAllowsAirPlay"
unit test which demonstrates that the allowsAirPlayForMediaPlayback is not
sticky (apparent Apple bug).
Also, "mediaPlaybackRequiresUserAction" configuration default differs on
iOS 10 versus earlier versions (on iOS 10 it defaults to YES, when it was NO,
previously). Probably due to:
https://webkit.org/blog/6784/new-video-policies-for-ios/
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-plugin-wkwebview-engine
CB-11074
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/13.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13
----
commit ec4350ab9b45b4e45413e30337d7a6e9e5bd5e22
Author: Shazron Abdullah <[email protected]>
Date: 2016-08-04T22:47:59Z
CB-11074 - Ensure settings from config.xml are taken into consideration
Note that there is a skipped unit test
"testConfigurationWithMediaPlaybackAllowsAirPlay", which deals with an Apple
bug in setting the WKWebViewConfiguration.allowsAirPlayForMediaPlayback value.
----
> WKWebView configuration is not considered
> -----------------------------------------
>
> Key: CB-11074
> URL: https://issues.apache.org/jira/browse/CB-11074
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin WKWebViewEngine
> Environment: ios
> Reporter: Alexis Kofman
> Assignee: Shazron Abdullah
> Priority: Critical
> Labels: ios, triaged
>
> Regarding the code of WKWebView.h, WKWebViewConfiguration seems to be a
> readonly property.
> {code}
> @property (nonatomic, readonly, copy) WKWebViewConfiguration *configuration;
> {code}
> But in this plugin, we are trying to update the WKWebView configuration after
> initialising it and it looks like all this part is not considered :
> https://github.com/apache/cordova-plugin-wkwebview-engine/blob/master/src/ios/CDVWKWebViewEngine.m#L146-L150
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
