[
https://issues.apache.org/jira/browse/CB-11683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15413160#comment-15413160
]
ASF GitHub Bot commented on CB-11683:
-------------------------------------
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/322
## [Current
coverage](https://codecov.io/gh/apache/cordova-android/pull/322?src=pr) is
33.78% (diff: 28.57%)
> Merging
[#322](https://codecov.io/gh/apache/cordova-android/pull/322?src=pr) into
[master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr)
will decrease coverage by **0.07%**
```diff
@@ master #322 diff @@
==========================================
Files 11 11
Lines 960 965 +5
Methods 197 197
Messages 0 0
Branches 156 157 +1
==========================================
+ Hits 325 326 +1
- Misses 635 639 +4
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update
[d54a42f...19eec15](https://codecov.io/gh/apache/cordova-android/compare/d54a42f0f0cfdab18c89e4a29de67c81f48f60b1...19eec150161872541d9a08401ff83e2528a36208?src=pr)
> Cordova-Android fails to properly add the source of a custom plugin if its
> source-file.src points to a directory and plugin is being installed in --link
> mode
> -------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CB-11683
> URL: https://issues.apache.org/jira/browse/CB-11683
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 3.5.0
> Environment: Windows 10
> Reporter: Szymon Drosdzol
> Priority: Minor
>
> I have cerated a custom plugin. In my plugin.xml I've added java sources
> directory with the following XML tag:
> {{<source-file src="src/com/thisisdir/" target-dir="src/com/" />}}
> Next I tried to install that plugin using the following command:
> {{cordova plugin add ..\AuthenticatorPlugin --link}}
> Unfortunatetly that only creates a useless 0-byte file in the destination
> folder instead of proper link.
> This resembles behaviour of Windows' mklink command, which does exactly this
> when trying to create the link to the directory without the /D parameter.
> This is clearly bad design. The command failed to do its job but exited
> normally instead of presenting any error message. Cordova shoudln't replicate
> that behaviour and handle folder linking on its own. Therefore we should
> either:
> * fail the task on attempts to link a directory,
> * handle directory linking properly.
> I think the second option is way better :)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
