[
https://issues.apache.org/jira/browse/CB-11687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421237#comment-15421237
]
ASF GitHub Bot commented on CB-11687:
-------------------------------------
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-lib/pull/480
CB-11687 platform-specific plugin prepare hooks should be run even wh…
…en no platforms are specified
DO NOT MERGE YET, discussion is needed
See details in [Jira](https://issues.apache.org/jira/browse/CB-11687)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daserge/cordova-lib CB-11687
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/480.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #480
----
commit b3d6712850c87f50ede88c45929b5d234e530af7
Author: daserge <[email protected]>
Date: 2016-08-15T16:23:37Z
CB-11687 platform-specific plugin prepare hooks should be run even when no
platforms are specified
----
> platform-specific plugin prepare hooks should be run even when no platforms
> are specified
> -----------------------------------------------------------------------------------------
>
> Key: CB-11687
> URL: https://issues.apache.org/jira/browse/CB-11687
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Reporter: Sergey Shakhnazarov
> Assignee: Sergey Shakhnazarov
>
> plugin.xml:
> {code}
> <platform name="windows">
> <hook type="before_build" src="hooks/windows/hook.js"/>
> <hook type="before_prepare" src="hooks/windows/hook.js"/>
> <hook type="after_build" src="hooks/windows/hook.js"/>
> <hook type="after_prepare" src="hooks/windows/hook.js"/>
> {code}
> hook.js:
> {code}
> module.exports = function(context) {
> console.log('context.hook: ' + context.hook);
> }
> {code}
> {{cordova prepare --verbose | findstr "context.hook"}} # no hooks runs
> {{cordova build --verbose | findstr "context.hook"}} # before_build,
> before_prepare, after_prepare, after_build runs
> Expected - {{cordova prepare}} should run plugin' platform-specific hooks as
> well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
