[
https://issues.apache.org/jira/browse/CB-9022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15426469#comment-15426469
]
ASF GitHub Bot commented on CB-9022:
------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/154
CB-9022 Resolve source URI on background thread in
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
This PR fixes application crash when trying to upload file from 'Content'
file system, specified by `cdvfile://localhost/content/...` URI.
### What testing has been done on this change?
Manual and automated testing
### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and
submitted to [email protected].
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
We should call `remapUri` on background thread otherwise it throws
`IllegalStateException` when trying to remap 'cdvfile://localhost/content/...'
URIs via `ContentFilesystem`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladimir-kotikov/cordova-plugin-file-transfer
CB-9022
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file-transfer/pull/154.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #154
----
commit 15551921f0304c4987d50d635aa2ea24a3a2c565
Author: Vladimir Kotikov <[email protected]>
Date: 2016-08-18T13:30:19Z
CB-9022 Resolve source URI on background thread in
We should call remapUri on background thread otherwise it
throws IllegalStateException when trying to remap
'cdvfile://localhost/content/...' URIs via ContentFilesystem
----
> Cordova Android Filetransfer returning null
> -"java.lang.IllegalStateException" - "CordovaInterface.getThreadPool()"
> -------------------------------------------------------------------------------------------------------------------
>
> Key: CB-9022
> URL: https://issues.apache.org/jira/browse/CB-9022
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
> Affects Versions: 1.1.0
> Environment: OS: Mac OS X Yosemite
> Node Version: v0.12.0
> Cordova CLI: 5.0.0
> Xcode version: Xcode 6.3.1 Build version 6D1002
> ios-sim version: 3.1.1
> ios-deploy version: 1.4.0
> android 4.0.0-dev
> Reporter: Mike Mullins
> Assignee: Vladimir Kotikov
> Labels: android, cannot-reproduce, wfc
>
> http://stackoverflow.com/questions/30201674/cordova-android-filetransfer-returning-null
> Attempting to do an android FileTransfer, plugin is working on iOS, i can't
> seem to get this to go!
> ADB lgocat output:
> E/PluginManager(23753): Uncaught exception from plugin
> E/PluginManager(23753): java.lang.IllegalStateException: Tried to perform an
> IO operation on the WebCore thread. Use CordovaInterface.getThreadPool()
> instead.
> FileTransferError
> body: null
> code: null
> exception: null
> http_status: null
> source: null
> target: null
> Trying a file transfer and coming back empty....
> Your system information:
> OS: Mac OS X Yosemite
> Node Version: v0.12.0
> Cordova CLI: 5.0.0
> Ionic CLI Version: 1.3.22
> Xcode version: Xcode 6.3.1 Build version 6D1002
> ios-sim version: 3.1.1
> ios-deploy version: 1.4.0
> ngCordova upload: http://ngcordova.com/docs/plugins/fileTransfer/
> Running in Crosswalk, not sure that makes any difference.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
