[
https://issues.apache.org/jira/browse/CB-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428284#comment-15428284
]
ASF GitHub Bot commented on CB-10973:
-------------------------------------
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/180
CB-10973 inAppBrowser for Windows Platform: wrong height of webview w…
…ith location=yes
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Windows
### What does this PR do?
Removes a transparent gap between x-ms-webview and bottom appbar.
### What testing has been done on this change?
Windows 8.1/10, Windows Phone 8.1/10, normal and fullscreen modes, portrait
and landscape orientations.
### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and
submitted to [email protected].
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
[Jira issue](https://issues.apache.org/jira/browse/CB-10973)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daserge/cordova-plugin-inappbrowser CB-10973
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/180.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #180
----
commit a77b289f0132e71f635cf692d816c47d42efe972
Author: daserge <[email protected]>
Date: 2016-08-19T14:43:48Z
CB-10973 inAppBrowser for Windows Platform: wrong height of webview with
location=yes
----
> inAppBrowser for Windows Platform: wrong height of webview with location=yes
> ----------------------------------------------------------------------------
>
> Key: CB-10973
> URL: https://issues.apache.org/jira/browse/CB-10973
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin InAppBrowser
> Affects Versions: 6.0.0
> Environment: Windows Phone 10, [email protected],
> [email protected]
> Reporter: Roberto De Simone
> Assignee: Sergey Shakhnazarov
> Labels: Windows, triaged
> Attachments: inAppBrowser-wrong-height.png
>
>
> When setting location=yes, the height of the webview is by some pixels too
> small. Please see attached screenshot with the green remarks.
> ref = cordova.InAppBrowser.open(h, '_blank', 'location=yes fullscreen=yes');
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
