[
https://issues.apache.org/jira/browse/CB-11705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429123#comment-15429123
]
ASF GitHub Bot commented on CB-11705:
-------------------------------------
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/241
Tested locally (passes - Travis CI had a hiccup with the simulator, above)
and did a code review, looks good to me.
Can you create a new docs PR for the new setting?
It should be in the same location as `CordovaWebViewEngine`:
http://cordova.apache.org/docs/en/latest/config_ref/index.html
The file location is:
https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/config_ref/index.md
(just click on the Edit button at that GH location to create a PR)
> [iOS-Cordova] Add configuration to override default WebViewEngine
> -----------------------------------------------------------------
>
> Key: CB-11705
> URL: https://issues.apache.org/jira/browse/CB-11705
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS
> Affects Versions: Master
> Reporter: Håkon Nilsen
> Labels: easyfix
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The introduction of WKWebView from iOS9 separed the WebView-interface to
> enable WKWebView and UIWebView. UIWebView is the default for all of Cordova
> unless WKWebView is specified, and always default for iOS 8.
> I think it is appropritate to be able to change the default UIWebView to
> whatever you'd want (i.e. WKWebView for iOS8 as well, or a different
> UIWebView plugin).
> I will supply a pull request.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
