[
https://issues.apache.org/jira/browse/CB-11757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438939#comment-15438939
]
ASF GitHub Bot commented on CB-11757:
-------------------------------------
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/113
CB-11757 (ios) Error out if trying to stop playback while in a wrong …
### Platforms affected
ios
### What does this PR do?
https://issues.apache.org/jira/browse/CB-11757
Makes ios implementation to send error callback when trying to stop the
playback when the avPlayer is not yet ready.
### What testing has been done on this change?
Manual and automated testing on iPad 2 with iOS 8.1
Also ran modified automated tests on Android 4.4 Emulator and on desktop
Windows 10.
### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and
submitted to [email protected].
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alsorokin/cordova-plugin-media CB-11757
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media/pull/113.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #113
----
commit ad047a1b26228717c4226289a0c4772eb02dc677
Author: Alexander Sorokin <[email protected]>
Date: 2016-08-26T09:48:50Z
CB-11757 (ios) Error out if trying to stop playback while in a wrong state
----
> media.stop() should call error callback when called in MEDIA_STARTING state
> ---------------------------------------------------------------------------
>
> Key: CB-11757
> URL: https://issues.apache.org/jira/browse/CB-11757
> Project: Apache Cordova
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: iOS, Plugin Media
> Affects Versions: Master
> Reporter: Alexander Sorokin
> Assignee: Alexander Sorokin
> Labels: triaged
>
> On iOS, when calling media.stop() when media is in state MEDIA_STARTING (for
> example, the player is caching media file), we don't get any callback. And
> then, when the caching is completed, the media actually starts playing.
> The proposed fix is that when media.stop() is called in an invalid state, the
> plugin should send an error callback with the code MEDIA_ERR_NONE_ACTIVE
> Another approach would be to stop the playback as soon as the player finishes
> caching. One possible advantage of this over the proposed fix would be that
> MEDIA_ERR_NONE_ACTIVE is not in w3c spec:
> https://dev.w3.org/html5/spec-author-view/video.html#error-codes
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
