[
https://issues.apache.org/jira/browse/CB-11771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439259#comment-15439259
]
ASF GitHub Bot commented on CB-11771:
-------------------------------------
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-android/pull/326
CB-11771 Deep symlink directories to target project instead of linking the
directory itself
When installing a plugin with custom library using the --link option the
whole directory is symlinked and temporary
files leak into the original plugin directory on build. This leads to
broken builds if the same plugin is linked in
2 projects targeting different Cordova versions.
fixes [CB-11771 Installing plugin with symlink option pollutes original
directory with intermediate
files](https://issues.apache.org/jira/browse/CB-11771)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Icenium/cordova-android bektchiev/deep-symlink
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/326.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #326
----
commit 817fc3ae70443e06ea9e6e6af298e7d839b0ff2a
Author: Martin Bektchiev <martin.bektch...@telerik.com>
Date: 2016-08-26T15:21:23Z
CB-11771 Deep symlink directories to target project instead of linking the
directory itself
When installing a plugin with custom library using the --link option the
whole directory is symlinked and temporary
files leak into the original plugin directory on build. This leads to
broken builds if the same plugin is linked in
2 projects targeting different Cordova versions.
----
> Installing plugin with symlink option pollutes original directory with
> intermediate files
> -----------------------------------------------------------------------------------------
>
> Key: CB-11771
> URL: https://issues.apache.org/jira/browse/CB-11771
> Project: Apache Cordova
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Plugman
> Affects Versions: 1.3.0
> Reporter: Martin Bektchiev
> Assignee: Martin Bektchiev
> Priority: Minor
>
> When installing a plugin with custom library using the --link option the
> whole directory is symlinked and temporary files leak into the original
> plugin directory on build. This leads to broken builds if the same plugin is
> linked in 2 projects targeting different Cordova versions.
> Steps to reproduce:
> * Clone https://github.com/Telerik-Verified-Plugins/Telerik-AppFeedback
> plugin (or any other with an embedded android library)
> * Create 2 test projects with Cordova Android 4.1.1 and 5.2
> * Install the plugin using the --link option of plugman in both projects
> * Build the Cordova 5.2 project
> * Attempt to build the Cordova 4.1.1 project - multiple java errors of the
> following kind are generated:
> Unknown source file : Uncaught translation error:
> java.lang.IllegalArgumentException: already added:
> Landroid/support/v7/appcompat/R$dimen;
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
