[
https://issues.apache.org/jira/browse/CB-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439552#comment-15439552
]
ASF GitHub Bot commented on CB-11380:
-------------------------------------
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/114
CB-11380 (ios) Overloaded audioFileForResource method instead of modi…
### Platforms affected
ios
### What does this PR do?
https://issues.apache.org/jira/browse/CB-11380
Overloads the audioFileForResource method instead of modifying its
signature because otherwise it would be an API breakage.
### What testing has been done on this change?
No testing whatsoever: I don't have an access to any iOS device till
tomorrow. Creating this PR to let CI test the changes.
### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and
submitted to [email protected].
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alsorokin/cordova-plugin-media CB-11380
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media/pull/114.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #114
----
commit 9f0c2e3e6bc1d76dcb0759f2aaf9e4137e391b09
Author: Alexander Sorokin <[email protected]>
Date: 2016-08-26T18:41:51Z
CB-11380 (ios) Overloaded audioFileForResource method instead of modifying
its signature
----
> Media Plugin - IOS: Error when creating Media object with new file
> ------------------------------------------------------------------
>
> Key: CB-11380
> URL: https://issues.apache.org/jira/browse/CB-11380
> Project: Apache Cordova
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Plugin Media
> Affects Versions: 2.3.0
> Environment: iOS 9.3.1
> Reporter: John Keating
> Assignee: Alexander Sorokin
> Labels: ios, media, url
>
> The line:
> {code:borderStyle=solid}var myMedia = new Media("documents://hello.wav",
> function() {
> console.log("success");
> },
> function(er) {
> console.log(er);
> }
> );
> {code}
> results in the error "Cannot use audio file from resource
> 'documents:hello.wav'", when "hello.wav" does not exist. The created Media
> object is usable (I can record and play back), but the error means the
> constructor's success callback never gets called. Also happens with
> variations of the src URI using "file" and "cdvfile".
> This is caused by a change to the validation parameter from NO to YES in
> commit e5b663ac951b2d8cb2e5e470d2c7072aa56cf779 on March 2nd.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
