[
https://issues.apache.org/jira/browse/CB-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446670#comment-15446670
]
ASF GitHub Bot commented on CB-5195:
------------------------------------
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/197#discussion_r76660251
--- Diff: src/android/CameraLauncher.java ---
@@ -927,6 +859,21 @@ private void writeUncompressedImage(Uri src, Uri dest)
throws FileNotFoundExcept
}
}
}
+ /**
+ * In the special case where the default width, height and quality are
unchanged
+ * we just write the file out to disk saving the expensive
Bitmap.compress function.
+ *
+ * @param src
+ * @throws FileNotFoundException
+ * @throws IOException
+ */
+ private void writeUncompressedImage(Uri src, Uri dest) throws
FileNotFoundException,
--- End diff --
I see two writeUncompressedImage functions. Is this correct? The second one
is right above this definition.
> Camera.getPicture with sourceType: PHOTOLIBRARY scales image before rotating
> ----------------------------------------------------------------------------
>
> Key: CB-5195
> URL: https://issues.apache.org/jira/browse/CB-5195
> Project: Apache Cordova
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Plugin Camera
> Affects Versions: 2.6.0
> Environment: Galaxy S4
> Reporter: Andre Asselin
> Labels: Android, reproduced, triaged
>
> Use Camera.getPicture() with sourceType: PHOTOLIBRARY to retrieve a picture
> from the library. If you specify both the correctOrientation and
> targetWidth/Height options (which currently you must do if you want
> correctOrientation to work because of bug CB-5194), the code scales the image
> first before rotating it, so the final dimensions are incorrect.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
