[
https://issues.apache.org/jira/browse/CB-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15486021#comment-15486021
]
ASF GitHub Bot commented on CB-11838:
-------------------------------------
GitHub user kenichi-fukushima opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/49
CB-11838 ios: Unregister callback function at the right timing.
### Platforms affected
iOS
### What does this PR do?
Make it so the CDVReachability object unregisters a callback function at
the right timing.
### What testing has been done on this change?
No automated test. I couldn't reproduce an issue that this patch fixes.
However, it suppressed a 40K daily crash reports at LINE.
### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and
submitted to [email protected].
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [N/A] Added automated test coverage as appropriate for this change.
We at LINE observed about 40K crashes a day that were suspected to be
caused by the reacahability callback function invoked on an
already-deallocated object. We couldn't reproduced the crash locally
but this patch did reduce the number of crash reports to zero.
You can merge this pull request into a Git repository by running:
$ git pull
https://github.com/kenichi-fukushima/cordova-plugin-network-information
reachability-callback
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-network-information/pull/49.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #49
----
commit 22a835ceac3339f6b5e595d7733f273c01aa0538
Author: Ken'ichi Fukushima <[email protected]>
Date: 2016-09-12T09:28:49Z
CB-11838 ios: Unregister callback function at the right timing.
We at LINE observed about 40K crashes a day that were suspected to be
caused by the reacahability callback function invoked on an
already-deallocated object. We couldn't reproduced the crash locally
but this patch did reduce the number of crash reports to zero.
----
> iOS network information plugin doesn't clean up itself correctly
> ----------------------------------------------------------------
>
> Key: CB-11838
> URL: https://issues.apache.org/jira/browse/CB-11838
> Project: Apache Cordova
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Plugin Network Information
> Environment: Cordova version: 4.1.0
> plugin version: 1.2.0
> iOS version: all
> iPhone/iPad version: all
> Reporter: Ken'ichi Fukushima
> Priority: Minor
>
> The CDVReachability class doesn't unregister a callback function that is
> registered in -startNotifier. We at LINE observe about 40K crash reports a
> day that are suspected to be caused by this. Our hypothesis is the callback
> function is called on an already deallocated object.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
