[ 
https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15495609#comment-15495609
 ] 

ASF GitHub Bot commented on CB-11858:
-------------------------------------

GitHub user tobiasviehweger opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/64

    CB-11858: Add possibility to utilize Android M feature "LightStatusBar"

    ### Platforms affected
    Android 6.0+
    
    ### What does this PR do?
    This PR adds support for the LightStatusBar style in Android. I re-used the 
already existing config "StatusBarStyle" for this, as it has a similar effect 
on iOS (changing the foreground color of the status bar to black instead of 
white).
    
    Something I'd like to discuss is, if "lightcontent" is the correct default 
value. The documentation says it is, but I don't think it actually is on iOS, 
is it? I think the iOS default is actually blackopaque?
    
    Let me know what you think :)
    
    ### What testing has been done on this change?
    Tested in emulator & on Samsung Galaxy S7.
    
    ### Checklist
    - [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sovanta/cordova-plugin-statusbar master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #64
    
----
commit 5ff4e56a921c2cd45a64a65505a21be66ec644c4
Author: Tobias Viehweger <tobias.viehwe...@gmail.com>
Date:   2016-09-15T15:34:45Z

    CB-11858: Add possibility to utilize Android M feature "LightStatusBar"

----


> Add possibility to utilize Android M feature "LightStatusBar"
> -------------------------------------------------------------
>
>                 Key: CB-11858
>                 URL: https://issues.apache.org/jira/browse/CB-11858
>             Project: Apache Cordova
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Plugin Statusbar
>    Affects Versions: 2.2.0
>         Environment: Android
>            Reporter: Tobias Viehweger
>            Priority: Minor
>              Labels: easyfix
>
> Since Android M, it's supported to have a light status bar, which will have 
> black text, instead of white text. That allows to have status bar backgrounds 
> that might be lighter than before.
> There is already something similar for iOS (StatusBarStyle), so it would be 
> easy to add. I already have the code here 
> (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830),
>  I just need to go through the ICLA signing.. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to