[ 
https://issues.apache.org/jira/browse/CB-11855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15496764#comment-15496764
 ] 

ASF GitHub Bot commented on CB-11855:
-------------------------------------

GitHub user soonahn reopened a pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/134

    CB-11855: (ios) Allow iOS to use hasPhoneNumber

    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Fixes https://issues.apache.org/jira/browse/CB-11855
    
    ### What testing has been done on this change?
    Tested on iOS 9.3 - iPhone 6.  As well as iOS Simulator of iPhone 6S
    
    ### Checklist
    - [ Yes ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed 
and submitted to secret...@apache.org.
    - [ Yes ] [Reported an 
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [ Yes ] Commit message follows the format: "CB-3232: (android) Fix bug 
with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the 
platform affected.
    - [ No ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soonahn/cordova-plugin-contacts 
allow_ios_to_filter_for_phone_number_only

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-contacts/pull/134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #134
    
----
commit 85b52d354caeb41ed79269cc9dce690ef41917c8
Author: Justin Ahn <jus...@soonahn.ca>
Date:   2016-09-15T06:39:33Z

    Capturing the default like the multiple option, and then continuing through 
the array if there are no phone numbers for the user

commit 03bae62e725bb6bca4eece731d28b5e78d0326ab
Author: Justin Ahn <jus...@soonahn.ca>
Date:   2016-09-16T16:36:01Z

    adding the bool option as well

----


> hasPhoneNumber does not work for iOS
> ------------------------------------
>
>                 Key: CB-11855
>                 URL: https://issues.apache.org/jira/browse/CB-11855
>             Project: Apache Cordova
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Plugin Contacts
>    Affects Versions: 6.3.0
>         Environment: osx, linux, ios
>            Reporter: Justin Ahn
>            Priority: Trivial
>              Labels: known_issue
>             Fix For: 6.3.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> hasPhoneNumber is an Android Only feature.  I'm proposing extending it to 
> allow iOS to use this feature as well



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to