ASF GitHub Bot commented on CB-3232:

GitHub user manucorporat opened a pull request:


    Fix handling of tel and mailto schemes in local file

    ### Platforms affected
    ### What does this PR do?
    - WKWebview appears to do nothing when 
`decisionHandler(WKNavigationActionPolicyAllow);` (accepting) a request with 
`tel` or `mailto` if the loaded file is local.
    ### What testing has been done on this change?
    - `<a href="tel:15555555"` and `window.open('tel:15555555')`
    ### Checklist
    - [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
    - [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/driftyco/cordova-plugin-wkwebview-engine 

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20
commit 40a229846d7da75876677bef717dd5dbc031993d
Author: Manu Mtz.-Almeida <manu.vallado...@gmail.com>
Date:   2016-09-13T14:22:24Z

    Fix handling of tel and mailto schemes in local file


> "cordova platform add blackberry" fails on 2.7.1-rc.1
> -----------------------------------------------------
>                 Key: CB-3232
>                 URL: https://issues.apache.org/jira/browse/CB-3232
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: BlackBerry, CLI
>    Affects Versions: 2.7.0
>            Reporter: Michael Brooks
>            Assignee: Michael Brooks
>             Fix For: 2.7.0
> The following error is thrown when running {{$ cordova platform add 
> blackberry}}:
> {code}
> [Error: An error occured during creation of blackberry sub-project. Creating 
> BlackBerry project...
> Updating config.xml ...
> sed: 
> /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml:
>  No such file or directory
> Cleaning up ...
> Remember to update the project.properties file inside your application 
> directory!
> ]
> {code}

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to