[ 
https://issues.apache.org/jira/browse/CB-11848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509194#comment-15509194
 ] 

ASF GitHub Bot commented on CB-11848:
-------------------------------------

GitHub user matrosovN opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/195

    CB-11848 windows: Remove duplicate slash after file system path

    <!--
    Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist
    is intended as a quick reference, for complete details please see our 
Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Windows
    
    ### What does this PR do?
    As we have always trailing slash after file system path we get invalid URI, 
for example ms-appdata:///temp//myfile.file, therefore we needn't leading slash 
in path argument. This PR removes it.
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matrosovN/cordova-plugin-file CB-11848

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/195.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #195
    
----
commit 35b7a25f9f1b469daca7386a85f9eb68b82110b9
Author: Nikita Matrosov <nikita.matro...@rp.ru>
Date:   2016-09-20T11:07:56Z

    CB-11848 windows: Remove duplicate slash after file system path
    
    As we have always trailing slash after file system path we get invalid URI, 
for example ms-appdata:///temp//myfile.file, therefore we needn't leading slash 
in path argument

----


> [Windows] File plugin, nativeUrl includes two slashes before filename
> ---------------------------------------------------------------------
>
>                 Key: CB-11848
>                 URL: https://issues.apache.org/jira/browse/CB-11848
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File
>            Reporter: Maarten Manders
>              Labels: windows
>
> The returned FileEntry object in the getFile function of a DirectoryEntry 
> object contains an incorrect nativeUrl that contains 2 slashes before the 
> filename (ie. ms-appdata:///temp//myfile.file).
> This can seemingly be resolved by changing the following line in the getFile 
> function in FileProxy.js:
> var fspath = sanitize(dirpath +'/'+ path);
> to
> var fspath = sanitize(path);
> I am unsure if this causes any side-effects however.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to