[ 
https://issues.apache.org/jira/browse/CB-11880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509373#comment-15509373
 ] 

ASF GitHub Bot commented on CB-11880:
-------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-android/pull/334
  
    ## [Current 
coverage](https://codecov.io/gh/apache/cordova-android/pull/334?src=pr) is 
35.15% (diff: 100%)
    > Merging 
[#334](https://codecov.io/gh/apache/cordova-android/pull/334?src=pr) into 
[master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) 
will not change coverage
    
    ```diff
    @@             master       #334   diff @@
    ==========================================
      Files            12         12          
      Lines          1007       1007          
      Methods         198        198          
      Messages          0          0          
      Branches        168        168          
    ==========================================
      Hits            354        354          
      Misses          653        653          
      Partials          0          0          
    ```
    
    > Powered by [Codecov](https://codecov.io?src=pr). Last update 
[f5ab6fc...5ef12c9](https://codecov.io/gh/apache/cordova-android/compare/f5ab6fc60203c54c4f4a7319a716d4c35ef1b326...5ef12c9b701580bfb4d4a16f368ce9157d9193ce?src=pr)


> cordova/exec crashes on Android when no [<args>] supplied
> ---------------------------------------------------------
>
>                 Key: CB-11880
>                 URL: https://issues.apache.org/jira/browse/CB-11880
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android
>            Reporter: Thomas Raffray
>            Priority: Minor
>
> When calling the function {code}cordova.exec(<successFunction>, 
> <failFunction>, <service>, <action>, [<args>]){code} without the last 
> argument, a TypeError is returned.
> The issue happens after cordova-android/cordova-js-src/exec.js tries to call 
> the length() function on args. As a result, the Cordova platform does not 
> invoke the native plugin code.
> Although the exec() prototype clearly requires the \[<args>\] parameter, the 
> iOS version of exec() makes a preliminary sanity check on this variable to 
> avoid generating an error.
> Suggest to replicate this behaviour on the Android platform to provide the 
> same fail-safe mechanism.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to