[ 
https://issues.apache.org/jira/browse/CB-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509460#comment-15509460
 ] 

ASF GitHub Bot commented on CB-11836:
-------------------------------------

Github user tsschaffert commented on the issue:

    https://github.com/apache/cordova-windows/pull/195
  
    1) The issue with Windows 10 should be fixed now, I handled it similarly to 
the 'ToastCapable' property.
    2) The color argument is now passed to the manifest file unchecked, so 
invalid values return an error like 'App manifest validation failed.' when 
building the project. Alternatively, we could throw a TypeError for invalid 
values?
    3) I added only a very basic test, as there were no comparable tests for 
the visualElement methods and I don't know enough about the internals to write 
really meaningful tests



> BackgroundColor cannot be set to white
> --------------------------------------
>
>                 Key: CB-11836
>                 URL: https://issues.apache.org/jira/browse/CB-11836
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Windows
>         Environment: Visual Studio 2015 Update 3, Apache Cordova 6.3.1, 
> cordova-windows 4.4.2
>            Reporter: Steffen Schaffert
>
> Recently, we tried to release an app version to the Windows Store (targeting 
> both Mobile and Desktop platforms)  with the BackgroundColor preference in 
> config.xml set to white (see below). 
> The build succeeded, but after submitting the app in the Windows Store, the 
> submission was declined as non-compliant, the reason being a low contrast 
> between background and foreground color. After some research, we discovered 
> the property "ForegroundText", which can be "light" or "dark", and which is 
> set to "light" per default in a Windows app. After changing this property 
> (which did not have a visible impact on our app, as we are using an image for 
> icon and splashscreen), the submission was successful. 
> As a more permanent solution, I added the functionality to change the 
> ForegroundText preference, similar to BackgroundColor, in the config.xml 
> file. I submitted this as a Pull Request 
> (https://github.com/apache/cordova-windows/pull/195).
> If there is a different solution to this problem, I would be glad to hear it, 
> otherwise I hope that the pull request can be used as a fix.
> Setting in config.xml which caused problems:
> {quote}
> <platform name="windows">
>     <preference name="BackgroundColor" value="#ffffff"/>
> </platform>
> {quote}
> Solution with fix applied:
> {quote}
> <platform name="windows">
>     <preference name="BackgroundColor" value="#ffffff"/>
>     <preference name="ForegroundText" value="dark"/>
> </platform>
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to