ASF GitHub Bot commented on CB-11817:

Github user hounsellal commented on the issue:

    This is very important. The file sizes are way smaller by this little 
change - I literally spent 2 days trying to compress the audio files with a 
lamejs library because they were so large - when such an easy fix would have 
saved me all that time.

> audioSettings shows as unused variable and settings are not used when 
> configuring a recorder
> --------------------------------------------------------------------------------------------
>                 Key: CB-11817
>                 URL: https://issues.apache.org/jira/browse/CB-11817
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Media
>    Affects Versions: 2.3.0
>         Environment: iOS
>            Reporter: Gaven Henry
>            Priority: Minor
>              Labels: easyfix
>   Original Estimate: 1h
>  Remaining Estimate: 1h
> xcode shows up 2 warnings when building within CDVSound.m
> 1) unused variable 'audioSettings'
> 2) Null passed to a callee that requires non-null when creating an 
> audioFile.recorder
> To resolve both of these just need to pass the autoSettings object to the 
> audioFile.recorder function.
> This resolves both warnings and actually applies the autoSettings as expected.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to