ASF GitHub Bot commented on CB-11875:

GitHub user audreyso opened a pull request:


    CB-11875 added android.hardware.location.gps uses-feature.

    Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist
    is intended as a quick reference, for complete details please see our 
Contributor Guidelines:
    ### Platforms affected
    ### What does this PR do?
    Fixes feature issue (geolocation)
    ### What testing has been done on this change?
    Tested that <uses-feature android:name="android.hardware.location.gps" />  
got added to Android manifest; Ran and tested that geolocation worked on 
Android device.
    ### Checklist
    - [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
    - [X] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/audreyso/cordova-plugin-geolocation CB-11875

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #81
commit 01dd58f7a607917736e92a01345a06a4fd643ea4
Author: Audrey So <a...@adobe.com>
Date:   2016-09-22T22:07:50Z

    CB-11875 added android.hardware.location.gps uses-feature.


> Cordova-Plugin-Geolocation requires feature android.hardware.location.gps 
> (android 21+)
> ---------------------------------------------------------------------------------------
>                 Key: CB-11875
>                 URL: https://issues.apache.org/jira/browse/CB-11875
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android, Plugin Geolocation
>            Reporter: Warren Parad
>            Assignee: Audrey So
>              Labels: easyfix, newbie, patch
>   Original Estimate: 24h
>  Remaining Estimate: 24h
> Hello Google Play Developer,
> We're writing to let you know that the apps listed at the end of this email 
> may be affected by an upcoming platform change.
> Action required: If your app requires GPS hardware to operate properly, you 
> will need to explicitly add the "android.hardware.location.gps" uses-feature 
> to your manifest.
> What’s changing
> We’re making a change on October 15th, 2016 that will affect apps targeting 
> API version 21 (Android 5.0, Lollipop) or higher that use 
> ACCESS_FINE_LOCATION but don't explicitly have the 
> "android.hardware.location.gps" uses-feature. Going forward, these apps will 
> be available to install on devices that don't have GPS hardware. In most 
> cases this won't be an issue since Wi-Fi and Cell-ID based location provides 
> high enough fidelity for the typical operation of these apps. However, any 
> apps that require GPS hardware, such as GPS navigators, should explicitly add 
> the *"android.hardware.location.gps" uses-feature* to their manifest.
> If your app requires GPS to function properly and you do not include 
> android.hardware.location.gps in your manifest declaration, your users may 
> have a poor app experience.
> Also, if you’re using the fused location provider and wish to receive the 
> most accurate location samples from GPS (i.e. with PRIORITY_HIGH_ACCURACY), 
> you must include the "android.hardware.location.gps" feature in your app’s 
> manifest to ensure that Google Play only distributes your app to devices with 
> GPS sensors.
> You can read more about this change in the Android Developers Help Center.
> Regards,
> The Google Play Team

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to