[
https://issues.apache.org/jira/browse/CB-11641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525285#comment-15525285
]
ASF GitHub Bot commented on CB-11641:
-------------------------------------
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/117
CB-11641 android: add 'message' field to media error
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
It was not possible before to get error message.This updated Android
implementation to return error code with message similar to iOS.
### What testing has been done on this change?
Auto test
### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and
submitted to [email protected].
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosov-nikita/cordova-plugin-media
CB-11641-check
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media/pull/117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #117
----
commit 9d0261c3ac9b7ccd1dc0d6873bd181f5121e6e68
Author: Nikita Matrosov <[email protected]>
Date: 2016-09-27T06:49:24Z
CB-11641 android: add 'message' field to media error
It was not possible before to get error message.This updated Android
implementation to return error code with message similar to iOS.
----
> MediaError object missing message member
> ----------------------------------------
>
> Key: CB-11641
> URL: https://issues.apache.org/jira/browse/CB-11641
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Media
> Affects Versions: 2.3.0
> Environment: Building on OSX 10.11.5, Android 5.1.1 and 5.2.0
> Reporter: Madison Dickson
> Assignee: Nikita Matrosov
> Priority: Minor
>
> on iOS, the MediaError object contains both the error code and the message.
> On Android, the object is missing the message.
> {code}
> new Media(this.src,
> // success callback
> successCallback,
> // error callback
> function(err) {
> console.log("recordAudio():Audio Error Code: "+ err.code + ", "+
> err.message, err);
> if(app.file){
> app.file.release();
> app.file = null;
> // app.stop();
> }
> }
> {code}
> outputs: {{recordAudio():Audio Error Code: 0, undefined}}
> I have seen both error code 0 and error code 1, the former of which is not
> documented.
> https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-media/index.html#mediaerror
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
