[
https://issues.apache.org/jira/browse/CB-11909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15527669#comment-15527669
]
ASF GitHub Bot commented on CB-11909:
-------------------------------------
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/139#discussion_r80812614
--- Diff: src/platform-release.js ---
@@ -128,14 +127,32 @@ exports.prepareReleaseBranchCommand = function*() {
'\n' +
'Usage: $0 prepare-release-branch --version=3.6.0 -r
platform')
);
+
var repos = flagutil.computeReposFromFlag(argv.r);
- var version = flagutil.validateVersionString(argv.version);
- var branchName = getVersionBranchName(version);
+ var branchName = null;
+
// First - perform precondition checks.
yield repoupdate.updateRepos(repos, [], true);
yield repoutil.forEachRepo(repos, function*(repo) {
+
+ var version = null;
+
+ if (argv.version === undefined) {
+ // Grabbing version from platformPackageJson
--- End diff --
minor: can you fix the indenting? the else should be in the same vertical
line as the if. comment should be inline with the vars, etc.
once you fix it, do a `git add platform-release.js` and then `git commit
--amend`. This will allow you to add the change to the existing commit instead
of creating a new commit. You will then have to push it with `git push audrey
master --force`
> Updating command in coho (prepare-release-branch) - grab the argv.version
> from package.json
> -------------------------------------------------------------------------------------------
>
> Key: CB-11909
> URL: https://issues.apache.org/jira/browse/CB-11909
> Project: Apache Cordova
> Issue Type: Bug
> Reporter: Audrey So
> Assignee: Audrey So
> Priority: Trivial
>
> If no version is passed in, grab the version from package.json
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
