[
https://issues.apache.org/jira/browse/CB-11860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15537524#comment-15537524
]
ASF GitHub Bot commented on CB-11860:
-------------------------------------
Github user dpogue commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/257#discussion_r81437882
--- Diff: bin/templates/scripts/cordova/lib/build.js ---
@@ -88,25 +89,61 @@ module.exports.run = function (buildOpts) {
events.emit('log','\tConfiguration: ' + configuration);
events.emit('log','\tPlatform: ' + (buildOpts.device ? 'device' :
'emulator'));
- var xcodebuildArgs = getXcodeArgs(projectName, projectPath,
configuration, buildOpts.device);
+ var xcodebuildArgs = getXcodeBuildArgs(projectName, projectPath,
configuration, buildOpts.device);
return spawn('xcodebuild', xcodebuildArgs, projectPath);
}).then(function () {
if (!buildOpts.device || buildOpts.noSign) {
return;
}
+
+ var exportOptions = {'compileBitcode': false};
+
+ if (buildOpts.packageType) {
+ exportOptions.method = buildOpts.packageType;
--- End diff --
@shazron We could default to "development" here...
> Cordova-iOS cannot package distributions apps with Xcode 8
> ----------------------------------------------------------
>
> Key: CB-11860
> URL: https://issues.apache.org/jira/browse/CB-11860
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Affects Versions: 4.3.0
> Reporter: Darryl Pogue
> Assignee: Darryl Pogue
>
> See mailing list thread:
> https://lists.apache.org/thread.html/85a715681471c774821d76a90ec288943eca1a4bb0a267ba299d2eb3@%3Cdev.cordova.apache.org%3E
> {quote}My proposal is for cordova-ios to drop support for Xcode 6 with the
> xcrun
> packaging, and start using xcodebuild for archiving and generating the IPA.
> I suppose that would have to wait for a major version bump of cordova-ios,
> unless we detected the Xcode version and kept the old code around
> conditionally.
> As part of packaging, we would need to generate a exportOptions.plist file,
> indicating what type of build to package (development, enterprise, ad-hoc,
> or app-store). I'd suggest we add a "packageType" or "buildType" field to
> build.json for specifying this value (with a default of development).{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
