[ 
https://issues.apache.org/jira/browse/CB-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552514#comment-15552514
 ] 

ASF GitHub Bot commented on CB-11955:
-------------------------------------

GitHub user pwlin opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/190

    CB-11955 (osx) Added Initial OSX platform support

    ### Platforms affected
    OSX
    
    ### What does this PR do?
    It adds preliminary support for OSX platform
    
    ### What testing has been done on this change?
    Running `npm test` on this changes shows no error.
    
    ### Checklist
    - [ x] [Reported an 
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [ x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [ ] Added automated test coverage as appropriate for this change.
    
    - Added src/osx plugin folder structure.
    - Added OSX platform to plugin.xml and package.json files.
    - Added _system target functionality for OSX.
    - Modified README.md to include information about OSX support.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pwlin/cordova-plugin-inappbrowser 
CB-11955cordova-plugin-inappbrowser

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #190
    
----
commit 804cec3e3f15544ef105630b358f3ded8b2aaa52
Author: pwlin <[email protected]>
Date:   2016-10-06T16:39:10Z

    CB-11955 Added Initial OSX platform support
    
    - Added src/osx plugin folder structure.
    - Added OSX platform to plugin.xml and package.json files.
    - Added _system target functionality for OSX.
    - Modified README.md to include information about OSX support.

----


> InAppBrowser - Add support for OSX
> ----------------------------------
>
>                 Key: CB-11955
>                 URL: https://issues.apache.org/jira/browse/CB-11955
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin InAppBrowser
>            Reporter: Tobias Bocanegra
>            Assignee: Tobias Bocanegra
>            Priority: Minor
>
> It would be great to support cordova-osx in the InAppBrowserPlugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to