[
https://issues.apache.org/jira/browse/CB-11952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15553266#comment-15553266
]
ASF GitHub Bot commented on CB-11952:
-------------------------------------
GitHub user adzellman opened a pull request:
https://github.com/apache/cordova-ios/pull/265
CB-11952 - Introduce buildFlag option
### Platforms affected
iOS
### What does this PR do?
- adds buildFlag option for passing args to xcodebuild
- There can be multiple --buildFlag declarations
- Warns if buildFlag would override a built-in setting
### What testing has been done on this change?
- Added unit tests for build.js
- I have tried this out with by passing various legal and illegal flags
using the --buildFlag option. I used the xcodebuild man page to develop test
cases.
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adzellman/aemm-ios CB-11952
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/265.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #265
----
commit e393738fe1f26824555bd090d1e08a725ed75f88
Author: Andrew Zellman <[email protected]>
Date: 2016-10-05T22:14:59Z
CB-11952 - Introduce buildFlag option
- adds buildFlag option for passing args to xcodebuild
- There can be multiple --buildFlag declarations
- Warns if buildFlag would override a built-in setting
----
> Should be able to pass flags to xcodebuild
> ------------------------------------------
>
> Key: CB-11952
> URL: https://issues.apache.org/jira/browse/CB-11952
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS
> Reporter: Andrew Zellman
> Assignee: Shazron Abdullah
> Labels: features
>
> Cordova developers should be able to pass additional flags to xcodebuild when
> compiling their projects. This can be done by adding a --buildFlag option in
> cordova-ios that allows multiples declarations. There will need to be
> additional attention to conflicts that may happen with xcodebuild arguments
> injected by Cordova.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
