[
https://issues.apache.org/jira/browse/CB-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556339#comment-15556339
]
ASF GitHub Bot commented on CB-11976:
-------------------------------------
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-lib/pull/497
CB-11976 - Add deprecated node version warning for 0.x
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
All
### What does this PR do?
Prints out a warning on `prepare` that you are using a deprecated node
version, if you are using any node version 0.x
### What testing has been done on this change?
Tested locally.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-lib CB-11976
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/497.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #497
----
commit 19031e645c1a885728c81650b55189cc311d1e13
Author: Shazron Abdullah <[email protected]>
Date: 2016-10-07T21:46:01Z
CB-11976 - Add deprecated node version warning for 0.x
----
> Add deprecated node version warning for 0.x
> -------------------------------------------
>
> Key: CB-11976
> URL: https://issues.apache.org/jira/browse/CB-11976
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
> Labels: cordova-7.0.0
>
> Put in the promise chain of prepare:
> https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/prepare.js
> Model it after this:
> https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/platform.js#L144-L150
> Check "process.version" for v0.x.x or v0.x, if they exist, print the warning.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
