[ https://issues.apache.org/jira/browse/CB-11962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15559819#comment-15559819 ]
ASF GitHub Bot commented on CB-11962: ------------------------------------- Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/83 I've merged the PR, but I didn't notice that your commits appear as obione user instead of obione86, you have something misconfigured in your computer, check https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/ I'll try to fix the history of commits to show you as the author, but you have to fix it too so it doesn't happen again > NSLocationWhenInUseUsageDescription in Info.plist is always empty and gets > reset to empty whenever the app is built. This improves the process of adding > the plugin so that the value is always set > --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: CB-11962 > URL: https://issues.apache.org/jira/browse/CB-11962 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Geolocation > Environment: iOS > Reporter: Obi Onuorah > Priority: Trivial > Original Estimate: 0h > Remaining Estimate: 0h > > When the geolocation plugin is added using the command > cordova plugin add cordova-plugin-geolocation > no value is added in the plugin.xml file for the > NSLocationWhenInUseUsageDescription even though it is in there it is empty. > Updating this Key directly in the plist and it always gets reset to empty. > Updating it in the plugin.xml means removing and adding or updating the > plugins might overwrite the value. > This fix simply adds it to the config.xml so that it can be specified on > installation using --variable or modified later by changing the value in the > config.xml, removing the plugin using cordova plugin rm and then running > cordova prepare which re-adds the plugin with the updated value of the key -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org