[
https://issues.apache.org/jira/browse/CB-11952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15562463#comment-15562463
]
ASF GitHub Bot commented on CB-11952:
-------------------------------------
GitHub user adzellman reopened a pull request:
https://github.com/apache/cordova-ios/pull/265
CB-11952 - Introduce buildFlag option
### Platforms affected
iOS
### What does this PR do?
- adds buildFlag option for passing args to xcodebuild
- There can be multiple --buildFlag declarations
- Warns if buildFlag would override a built-in setting
### What testing has been done on this change?
- Added unit tests for build.js
- I have tried this out with by passing various legal and illegal flags
using the --buildFlag option. I used the xcodebuild man page to develop test
cases.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adzellman/aemm-ios CB-11952
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/265.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #265
----
commit e393738fe1f26824555bd090d1e08a725ed75f88
Author: Andrew Zellman <[email protected]>
Date: 2016-10-05T22:14:59Z
CB-11952 - Introduce buildFlag option
- adds buildFlag option for passing args to xcodebuild
- There can be multiple --buildFlag declarations
- Warns if buildFlag would override a built-in setting
commit d614152e7eafd57527de7f37dee757250c3fa3ad
Author: Andrew Zellman <[email protected]>
Date: 2016-10-06T23:20:14Z
Remove the optional import of check_reqs.
- Use a try-catch instead, because it actually works.
commit 6d0cc7c56dc4e4e9c93e0a842e92c24964cc6d0e
Author: Andrew Zellman <[email protected]>
Date: 2016-10-06T23:26:30Z
Use util for string formatting of warning.
commit cbf4bac766467c150657d09fd9b5956bbf285b9d
Author: Andrew Zellman <[email protected]>
Date: 2016-10-07T17:09:29Z
Make changes for using workspace instead of project.
commit 68ab00a474ef947e5b2796e596cf23e5c3d8af75
Author: Andrew Zellman <[email protected]>
Date: 2016-10-08T01:12:03Z
Merge branch 'master' of https://github.com/apache/cordova-ios into CB-11952
commit 2b221fd38170486756bc0667fdc62acc0ce8d011
Author: Andrew Zellman <[email protected]>
Date: 2016-10-08T03:04:10Z
Fix up options in response to PR #257
----
> Should be able to pass flags to xcodebuild
> ------------------------------------------
>
> Key: CB-11952
> URL: https://issues.apache.org/jira/browse/CB-11952
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS
> Reporter: Andrew Zellman
> Assignee: Shazron Abdullah
> Labels: features
> Fix For: [email protected]
>
>
> Cordova developers should be able to pass additional flags to xcodebuild when
> compiling their projects. This can be done by adding a --buildFlag option in
> cordova-ios that allows multiples declarations. There will need to be
> additional attention to conflicts that may happen with xcodebuild arguments
> injected by Cordova.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
