ASF GitHub Bot commented on CB-12011:

GitHub user MartijnW49 opened a pull request:


    CB-12011: (android) added the possibility to change the spinner color…

    ### Platforms affected
    ### What does this PR do?
    It adds the possibility to change the spinner color from the config.xml 
file for android 5.0+ apps.
    Example config.xml line:
    <preference name="SplashScreenSpinnerColor" value="white"/>
    Color names as well as hex colors can be used.
    ### What testing has been done on this change?
    Tested the updated Splashscreen.java in an ionic 2 app. The splashscreen 
works and shows the spinner in the color that was defined in the config.xml
    ### Checklist
    - [x ] [Reported an 
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
    - [x ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MartijnW49/cordova-plugin-splashscreen 

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #116
commit a13a07960ce863c990956b4194f3ed0d9923ae40
Author: MartijnW49 <willeke...@gmail.com>
Date:   2016-10-13T12:20:32Z

    CB-12011: (android) added the possibility to change the spinner color on 
Android 5.0+ apps


> Change color of the spinner for android 5.0+
> --------------------------------------------
>                 Key: CB-12011
>                 URL: https://issues.apache.org/jira/browse/CB-12011
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: Plugin SplashScreen
>         Environment: Android 5.0+
>            Reporter: Martijn Willekens
>              Labels: android, android5.0, android6.0
>   Original Estimate: 1h
>  Remaining Estimate: 1h
> Since Android 5.0 there is a new spinner which color depends on the theme 
> that is used for the Android app. It defaults to an ugly green. This change 
> will allow the color of the spinner to be set from the config.xml.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to