[ 
https://issues.apache.org/jira/browse/CB-11951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573709#comment-15573709
 ] 

ASF GitHub Bot commented on CB-11951:
-------------------------------------

Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/501#discussion_r83341216
  
    --- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
    @@ -203,6 +204,23 @@ describe('plugin end-to-end', function() {
             .fin(done);
         });
     
    +    it('should respect preference default values', function (done) {    
    +       addPlugin(path.join(pluginsDir, org_test_defaultvariables), 
org_test_defaultvariables, {cli_variables: { REQUIRED:'NO', 
REQUIRED_ANDROID:'NO'}}, done)
    +       .then(function() {
    +            var platformJsonPath = path.join(project, 'plugins', 
helpers.testPlatform + '.json');
    +            var installed_plugins = 
JSON.parse(fs.readFileSync(platformJsonPath)).installed_plugins;
    --- End diff --
    
    Instead of `JSON.parse` & `fs.readFileSync`, why not use 
    ```var installed_plugins = require('platformJsonPath').installed_plugins;```
    
    That would remove the need to `require('fs')`


> Plugin preference default value is not being saved to <platform>.json
> ---------------------------------------------------------------------
>
>                 Key: CB-11951
>                 URL: https://issues.apache.org/jira/browse/CB-11951
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI, CordovaLib
>    Affects Versions: 6.3.1
>         Environment: Windows 10 with anniversary update
>            Reporter: Alexander Sorokin
>            Assignee: Nikita Matrosov
>
> Plugin preference default value is not being saved to <platform>.json
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android
> cordova plugin add cordova-plugin-ms-azure-mobile-engagement --variable 
> AZME_ANDROID_CONNECTION_STRING=Endpoint=0;AppId=0;SdkKey=0 --variable 
> AZME_ENABLE_PLUGIN_LOG=false
> {noformat}
> check out `./platforms/android/android.json` or `./pluguns/android.json`
> it has the following lines:
> {code}
> "installed_plugins": {
>         <...>
>         "cordova-plugin-ms-azure-mobile-engagement": {
>             "AZME_ENABLE_PLUGIN_LOG": "false",
>             "AZME_ANDROID_GOOGLE_PROJECT_NUMBER": "null",
>             "AZME_ANDROID_REACH_ICON": "icon",
>             "AZME_ANDROID_CONNECTION_STRING": "Endpoint=0;AppId=0;SdkKey=0",
>             "PACKAGE_NAME": "io.cordova.hellocordova"
>         }
>     },
> {code}
> You can see that "AZME_ENABLE_PLUGIN_LOG" is saved here, while 
> "AZME_ENABLE_NATIVE_LOG" is not.
> They both can be found in the plugin section of the  plugin's `plugin.xml` 
> file:
> https://github.com/Azure/azure-mobile-engagement-cordova/blob/master/plugin.xml#L29
> Note that the Android-specific preferences have been saved correctly.
> cordova@6.3.0 doesn't have this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to