ASF GitHub Bot commented on CB-12020:

GitHub user sfrank87 opened a pull request:


    CB-12020 Android and iOS: add a method to hide an InAppBrowser after it was 

    ### Platforms affected
    Android, iOS
    ### What does this PR do?
    add a hide() method to hide the InAppBrowser. You can make it reappear my 
calling the show() method (again).
    ### What testing has been done on this change?
    - automated test: check for the existence of the hide() method
    - manual test: open InAppBrowser visible, than hide it (after 2 seconds)
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
    - [X] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sfrank87/cordova-plugin-inappbrowser 

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #192
commit 157116caebec508ac8e9dce5e8bfa94a4d0fcc2a
Author: Frank Stingl <stingl.fr...@inside-online.de>
Date:   2016-10-14T12:48:31Z

    CB-12020 Android and iOS: add a method to hide an InAppBrowser after it was 


> add a method to hide an InAppBrowser after it was shown
> -------------------------------------------------------
>                 Key: CB-12020
>                 URL: https://issues.apache.org/jira/browse/CB-12020
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: Plugin InAppBrowser
>         Environment: Android, iOS
>            Reporter: Frank Stingl
>              Labels: android, ios
> The InAppBrowser plugin, unfortunately, offers no ability to hide an 
> InAppBrowser after it was shown. Because I had a need for such a 
> functionality, I implemented it. :)
> Now, you can call the hide() method to make the InAppBrowser disappear. Then, 
> call show() to have it reappearing.
> However, after I finished my work, I recognized that there was a similar Jira 
> issue #cb-8467, but, I don’t know why, it was not merged upstream until today.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to