[ 
https://issues.apache.org/jira/browse/CB-11730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575596#comment-15575596
 ] 

ASF GitHub Bot commented on CB-11730:
-------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-lib/pull/484
  
    ## [Current 
coverage](https://codecov.io/gh/apache/cordova-lib/pull/484?src=pr) is 80.43% 
(diff: 100%)
    > Merging [#484](https://codecov.io/gh/apache/cordova-lib/pull/484?src=pr) 
into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) 
will decrease coverage by **0.35%**
    
    ```diff
    @@             master       #484   diff @@
    ==========================================
      Files            68         67     -1   
      Lines          5407       5197   -210   
      Methods         857        838    -19   
      Messages          0          0          
      Branches       1048       1007    -41   
    ==========================================
    - Hits           4368       4180   -188   
    + Misses         1039       1017    -22   
      Partials          0          0          
    ```
    
    > Powered by [Codecov](https://codecov.io?src=pr). Last update 
[3b38b53...3c92340](https://codecov.io/gh/apache/cordova-lib/compare/3b38b5382b9a52d1fe522514b61d3ebd6016796d...3c923408cb83597d551ee6c6c3b50746f8782788?src=pr)


> plugman miss the last file/folder when installing plugin on windows
> -------------------------------------------------------------------
>
>                 Key: CB-11730
>                 URL: https://issues.apache.org/jira/browse/CB-11730
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 6.3.1
>         Environment: Windows
> plugman --version
> 1.2.1
> cordova --version
> 6.3.1
>            Reporter: Yasuharu Seki
>            Priority: Minor
>              Labels: triaged
>
> Steps to reproduce:
> - Create simple plugin
> $ plugman create --name SimplePlugin --plugin_id org.simple.plugin 
> --plugin_version 1.0.0
> - Create cordova project it includes the name of plugin
> $ cordova create SimplePlugin_TestBed
> - Install the plugin into the created project
> $ cordova plugin add ../SimplePlugin
> -> Check the plugins/org.simple.plugin folder
>   Find www/ folder is missing.
> The reason is filenames.indexOf(relativeRootFolder) returns -1 when the 
> target folder name cannot find in the plugin folder.
> The original code works good when the project is on the child folder.
> [plugin]/[project of plugin_testbed]
> But does not the project as sibling.
> [plugin]
> [project of plugin_testbed]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to