[ 
https://issues.apache.org/jira/browse/CB-11951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15577042#comment-15577042
 ] 

ASF subversion and git services commented on CB-11951:
------------------------------------------------------

Commit afcffc59ad186ae98518ac890fd942d3ca7069d8 in cordova-lib's branch 
refs/heads/master from [~Nikita Matrosov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=afcffc5 ]

CB-11951 CB-11967: Respect preference default values when install plugin


> Plugin preference default value is not being saved to <platform>.json
> ---------------------------------------------------------------------
>
>                 Key: CB-11951
>                 URL: https://issues.apache.org/jira/browse/CB-11951
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI, CordovaLib
>    Affects Versions: 6.3.1
>         Environment: Windows 10 with anniversary update
>            Reporter: Alexander Sorokin
>            Assignee: Nikita Matrosov
>
> Plugin preference default value is not being saved to <platform>.json
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android
> cordova plugin add cordova-plugin-ms-azure-mobile-engagement --variable 
> AZME_ANDROID_CONNECTION_STRING=Endpoint=0;AppId=0;SdkKey=0 --variable 
> AZME_ENABLE_PLUGIN_LOG=false
> {noformat}
> check out `./platforms/android/android.json` or `./pluguns/android.json`
> it has the following lines:
> {code}
> "installed_plugins": {
>         <...>
>         "cordova-plugin-ms-azure-mobile-engagement": {
>             "AZME_ENABLE_PLUGIN_LOG": "false",
>             "AZME_ANDROID_GOOGLE_PROJECT_NUMBER": "null",
>             "AZME_ANDROID_REACH_ICON": "icon",
>             "AZME_ANDROID_CONNECTION_STRING": "Endpoint=0;AppId=0;SdkKey=0",
>             "PACKAGE_NAME": "io.cordova.hellocordova"
>         }
>     },
> {code}
> You can see that "AZME_ENABLE_PLUGIN_LOG" is saved here, while 
> "AZME_ENABLE_NATIVE_LOG" is not.
> They both can be found in the plugin section of the  plugin's `plugin.xml` 
> file:
> https://github.com/Azure/azure-mobile-engagement-cordova/blob/master/plugin.xml#L29
> Note that the Android-specific preferences have been saved correctly.
> cordova@6.3.0 doesn't have this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to