[ 
https://issues.apache.org/jira/browse/CB-11933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581977#comment-15581977
 ] 

ASF GitHub Bot commented on CB-11933:
-------------------------------------

Github user daserge commented on the issue:

    https://github.com/apache/cordova-windows/pull/202
  
    Thanks, @matrosov-nikita !
    I've tested and this works in terms of removing the added Capabilities.
    Although the issue described in 
https://issues.apache.org/jira/browse/CB-11933 remains - that uap: prefixes are 
not added on plugin add.
    So if you create a project in CLI, add a plugin and then open solution in 
Visual Studio - capabilities will not actually work.


> [windows] uap: not added on plugin add
> --------------------------------------
>
>                 Key: CB-11933
>                 URL: https://issues.apache.org/jira/browse/CB-11933
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>            Reporter: Sergey Shakhnazarov
>            Assignee: Nikita Matrosov
>
> {noformat}
> cordova create test
> cd test
> cordova platform add https://github.com/apache/cordova-windows
> cordova plugin add 
> https://github.com/AzureAD/azure-activedirectory-library-for-cordova
> cordova plugin add plugins\cordova-plugin-ms-adal\src\windows\sso\
> type platforms\windows\package.windows10.appxmanifest
> {noformat}
> ->
> {noformat}
>     <Capabilities>
>         <Capability Name="internetClient" />
>         <Capability Name="enterpriseAuthentication" />
>         <Capability Name="privateNetworkClientServer" />
>         <Capability Name="sharedUserCertificates" />
>     </Capabilities>
> {noformat}
> {{cordova prepare}}
> {noformat}
> type platforms\windows\package.windows10.appxmanifest
> {noformat}
> {noformat}
>     <Capabilities>
>         <Capability Name="internetClient" />
>         <uap:Capability Name="enterpriseAuthentication" />
>         <Capability Name="privateNetworkClientServer" />
>         <uap:Capability Name="sharedUserCertificates" />
>     </Capabilities>
> {noformat}
> {{cordova plugin rm cordova-plugin-ms-adal-sso}}
> {noformat}
> type platforms\windows\package.windows10.appxmanifest
> {noformat}
> {noformat}
>     <Capabilities>
>         <Capability Name="internetClient" />
>         <uap:Capability Name="enterpriseAuthentication" />
>         <uap:Capability Name="sharedUserCertificates" />
>     </Capabilities>
> {noformat}
> 1. uap: prefixes not being added on plugin add
> 2. cordova prepare fixes this
> 3. plugin rm does not remove added capabilities as they have been changed
> cordova-plugin-ms-adal-sso plugin.xml:
> {noformat}
>     <platform name="windows">
>         <js-module name="overrides" src="www/overrides.js">
>             <runs />
>         </js-module>
>         <config-file target="package.appxmanifest" 
> parent="/Package/Capabilities" device-target="windows">
>             <Capability Name="enterpriseAuthentication" />
>             <Capability Name="privateNetworkClientServer" />
>             <Capability Name="sharedUserCertificates" />
>         </config-file>
>     </platform>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to