[ 
https://issues.apache.org/jira/browse/CB-11979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15587053#comment-15587053
 ] 

ASF GitHub Bot commented on CB-11979:
-------------------------------------

Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/504#discussion_r83974283
  
    --- Diff: cordova-lib/src/plugman/fetch.js ---
    @@ -70,6 +70,10 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
                 //if --fetch was used, throw error for subdirectories
                 if (result[2] && options.fetch) {
                     return Q.reject(new CordovaError('--fetch does not support 
subdirectories'));
    +            } else {
    +                if(result[2]) {
    +                    events.emit('warn', 'support for subdirectories is 
depreated and will be removed in Cordova@7');
    +                }
    --- End diff --
    
    if fetch and subdirectory are both present, it will just do a straight 
reject return Q.reject(new CordovaError('--fetch does not support 
subdirectories'));


> add deprecation notice for using subdirectory syntax when fetching plugins
> --------------------------------------------------------------------------
>
>                 Key: CB-11979
>                 URL: https://issues.apache.org/jira/browse/CB-11979
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 6.3.1
>            Reporter: Steve Gill
>              Labels: cordova-7.0.0
>             Fix For: 6.4.0
>
>
> We plan to remove subdirectory syntax in cordova@7 since `--fetch` can't 
> support it. 
> Need to add a deprecation to the next cordova@6.x release to start warning 
> folks it is going away.
> You can see the subdirectory syntax at 
> http://cordova.apache.org/docs/en/latest/reference/cordova-cli/index.html#plugin-spec.
> I think it is plugin specific, but need to double check it is not supported 
> for fetching platforms too. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to