Giuseppe La Torre created CB-12036:
--------------------------------------

             Summary: Exception on prepare when no SplashScreen node not found 
in manifest
                 Key: CB-12036
                 URL: https://issues.apache.org/jira/browse/CB-12036
             Project: Apache Cordova
          Issue Type: Bug
          Components: Windows
    Affects Versions: 4.4.3
            Reporter: Giuseppe La Torre


This is a mirror of the pull: https://github.com/apache/cordova-windows/pull/196

The issue is:
running prepare, the function setSplashBgColor on AppManifest.js throws 
exception when then splashscreen node is not found in the manifest.

The scenario:
Windows allows to have an app with NO splashscreen at all. You can either 
remove the node manually or, like me, I use hook to remove it because cordova 
actually doesn't support such a feature.
So, the code in that function crashes because it assumes a splashscreen exists, 
but the node is optional in the manifest.
The solution is easy: check if the node exists before doing stuff. No more than 
that. The pull request implements that simply if.

Please, don't delay because the missing feature. The issue is beyond that, the 
code is wrong because the assumption is false.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to