[
https://issues.apache.org/jira/browse/CB-12036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15594793#comment-15594793
]
ASF subversion and git services commented on CB-12036:
------------------------------------------------------
Commit c3b109c937cd75ad3b35df1ec0dde753b1b13e59 in cordova-windows's branch
refs/heads/master from giuseppelt
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=c3b109c ]
CB-12036 Fix setSplashBgColor exception when no splashscreen is found
WindowsPhone allows to unset splashscreen (img) to avoid it to be shown.
This patch fixes whenever the "splashscreen" node is not present.
This closes #196
> Exception on prepare when no SplashScreen node not found in manifest
> --------------------------------------------------------------------
>
> Key: CB-12036
> URL: https://issues.apache.org/jira/browse/CB-12036
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Affects Versions: 4.4.3
> Reporter: Giuseppe La Torre
> Priority: Minor
>
> This is a mirror of the pull:
> https://github.com/apache/cordova-windows/pull/196
> The issue is:
> running prepare, the function setSplashBgColor on AppManifest.js throws
> exception when then splashscreen node is not found in the manifest.
> The scenario:
> Windows allows to have an app with NO splashscreen at all. You can either
> remove the node manually or, like me, use a hook to remove it because cordova
> actually doesn't support such a feature.
> So, the code in that function crashes because it assumes a splashscreen
> exists, but the node is optional in the manifest.
> The solution is easy: check if the node exists before doing stuff. No more
> than that. The pull request implements that simply if.
> Please, don't delay because the missing feature. The issue is beyond that,
> the code is wrong because the assumption is false.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
