[ 
https://issues.apache.org/jira/browse/CB-12100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625900#comment-15625900
 ] 

ASF GitHub Bot commented on CB-12100:
-------------------------------------

GitHub user alsorokin opened a pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/163

    CB-12100 (ios) Fixed test plugin install at platform add on cordova@6…

    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Fixes the problem described here: 
https://issues.apache.org/jira/browse/CB-12100
    "cordova platform add ios" would fail on cordova@6.3.1 when "file transfer 
tests" plugin is added to the project.
    
    ### What testing has been done on this change?
    Manual platform rm/add and paramedic run for iOS with cordova@6.3.1 as well 
as with cordova@6.4.0
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [x] Added automated test coverage as appropriate for this change - this 
is already being tested via [this Jenkins 
job](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-toolset/).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alsorokin/cordova-plugin-file-transfer 
CB-12100

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file-transfer/pull/163.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #163
    
----
commit addf885c7474422d4d5bfed62544f7f0425c23c4
Author: Alexander Sorokin <alexander.soro...@akvelon.com>
Date:   2016-11-01T16:15:32Z

    CB-12100 (ios) Fixed test plugin install at platform add on cordova@6.3.1

----


> "cordova platform add ios" fails to install 
> "cordova-plugin-file-transfer-tests"
> --------------------------------------------------------------------------------
>
>                 Key: CB-12100
>                 URL: https://issues.apache.org/jira/browse/CB-12100
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File Transfer
>    Affects Versions: Master
>         Environment: cordova@6.3.1
>            Reporter: Alexander Sorokin
>            Assignee: Alexander Sorokin
>            Priority: Minor
>              Labels: found-by-ci, triaged
>
> This happens only on cordova@6.3.1 and only with ios platform
> http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-toolset/lastFailedBuild/CORDOVA=6.3.1,PLATFORM=ios/console
> {noformat}
> + cordova --version
> 6.3.1
> + node cordova-paramedic/main.js --config 
> cordova-medic/jenkins-conf/pr/local/ios.config.json --plugin 
> ./cordova-plugin-file-transfer --outputDir 
> /Users/jenkins/jenkins/workspace/cordova-plugin-file-transfer-toolset
> cordova-paramedic: creating temp project at 
> /var/folders/nd/5vd2nqsn3tlc6kljds0c95200000gp/T/tmp-9464969bwj8D0ME1t
> Creating a new cordova project.
> /private/var/folders/nd/5vd2nqsn3tlc6kljds0c95200000gp/T/tmp-9464969bwj8D0ME1t
>  /Users/jenkins/jenkins/workspace/cordova-plugin-file-transfer-toolset
> cordova-paramedic: installing plugins
> cordova-paramedic: installing 
> /Users/jenkins/jenkins/workspace/cordova-plugin-file-transfer-toolset/cordova-plugin-file-transfer
> cordova-paramedic: installing 
> /var/folders/nd/5vd2nqsn3tlc6kljds0c95200000gp/T/tmp-9464969bwj8D0ME1t/plugins/cordova-plugin-file-transfer/tests
>  --variable FILETRANSFER_SERVER_ADDRESS=http://127.0.0.1:5000
> cordova-plugin-file-transfer 1.6.1-dev "File Transfer"
> cordova-plugin-file-transfer-tests 1.6.1-dev "Cordova File Transfer Plugin 
> Tests"
> cordova-paramedic: installing cordova-plugin-test-framework
> Fetching plugin "cordova-plugin-test-framework" via npm
> cordova-paramedic: installing cordova-plugin-device
> Fetching plugin "cordova-plugin-device" via npm
> cordova-paramedic: installing 
> /Users/jenkins/jenkins/workspace/cordova-plugin-file-transfer-toolset/cordova-paramedic/paramedic-plugin
> cordova-paramedic: installing 
> /Users/jenkins/jenkins/workspace/cordova-plugin-file-transfer-toolset/cordova-paramedic/ios-geolocation-permissions-plugin
> cordova-paramedic: setting app start page to test page
> cordova-paramedic: adding platform ios
> Adding ios project...
> Creating Cordova project for the iOS platform:
>       Path: platforms/ios
>       Package: io.cordova.hellocordova
>       Name: HelloCordova
> iOS project created with cordova-ios@4.2.1
> Installing "cordova-plugin-device" for ios
> Installing "cordova-plugin-file-transfer" for ios
> Fetching plugin "cordova-plugin-file" via npm
> Installing "cordova-plugin-file" for ios
> Fetching plugin "cordova-plugin-compat" via npm
> Installing "cordova-plugin-compat" for ios
> The Android Persistent storage location now defaults to "Internal". Please 
> check this plugins README to see if you application needs any changes in its 
> config.xml.
> If this is a new application no changes are required.
> If this is an update to an existing application that did not specify an 
> "AndroidPersistentFileLocation" you may need to add:
>       "<preference name="AndroidPersistentFileLocation" value="Compatibility" 
> />"
> to config.xml in order for the application to find previously stored files.
>     
> Installing "cordova-plugin-file-transfer-tests" for ios
> Installing "cordova-plugin-paramedic" for ios
> Installing "cordova-plugin-test-framework" for ios
> Installing "ios-geolocation-permissions-plugin" for ios
> Error: Cannot read property 'FILETRANSFER_SERVER_ADDRESS' of undefined
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to