[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635985#comment-15635985
 ] 

ASF GitHub Bot commented on CB-11154:
-------------------------------------

GitHub user kosssi opened a pull request:

    https://github.com/apache/cordova-plugin-globalization/pull/53

    CB-11154: (Android, iOS) Add IANA timezone

    <!--
    Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist
    is intended as a quick reference, for complete details please see our 
Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android, iOS
    
    ### What does this PR do?
    Add IANA timezone
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cozy/cordova-plugin-globalization master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-globalization/pull/53.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #53
    
----
commit 247e4027124f1792e33ea2377efa1ec721d7b726
Author: Simon Constans <[email protected]>
Date:   2016-11-04T09:50:06Z

    CB-11154: (Android, iOS) Add IANA timezone

----


> Why timezone is not IANA ?
> --------------------------
>
>                 Key: CB-11154
>                 URL: https://issues.apache.org/jira/browse/CB-11154
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Globalization
>            Reporter: Simon Constans
>              Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to