[
https://issues.apache.org/jira/browse/CB-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655554#comment-15655554
]
ASF GitHub Bot commented on CB-12130:
-------------------------------------
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/276
## [Current
coverage](https://codecov.io/gh/apache/cordova-ios/pull/276?src=pr) is 60.00%
(diff: 50.00%)
> Merging [#276](https://codecov.io/gh/apache/cordova-ios/pull/276?src=pr)
into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr)
will not change coverage
```diff
@@ master #276 diff @@
==========================================
Files 12 12
Lines 1325 1325
Methods 202 202
Messages 0 0
Branches 224 224
==========================================
Hits 795 795
Misses 530 530
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update
[50a185a...1a1dee4](https://codecov.io/gh/apache/cordova-ios/compare/50a185a6ec9e1b231cf0cddaddb6f74101c93f38...1a1dee4613f66ebf69164dc6ce2063d7a20947eb?src=pr)
> Launch storyboard images are not updated or cleaned
> ---------------------------------------------------
>
> Key: CB-12130
> URL: https://issues.apache.org/jira/browse/CB-12130
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Affects Versions: Master, 4.3.0
> Reporter: Niels Leenheer
> Fix For: [email protected]
>
>
> Launch storyboard images were not updated or cleaned in
> updateLaunchStoryboardImages() or cleanLaunchStoryboardImages()
> because the check for Images.xcassets in
> getLaunchStoryboardImagesDir() failed.
> The reason was that the platformProjDir and projectRoot were
> joined, while both were relative to the root directory. So the
> resulting directory was non-sensical. This changes makes
> platformProjDir relative to cordovaProject.root, which matches the
> same check in updateSplashScreens() and updateIcons().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
