[
https://issues.apache.org/jira/browse/CB-8976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15673375#comment-15673375
]
Andreas Kohn commented on CB-8976:
----------------------------------
The code for this has been committed, and releases have been created with it.
Still, this issue is marked as open, and I completely missed in any release
notes for cordova/cordova-android. Just like [~tflessak] I got burned by this
one now.
It's nice to stop the magic being done here, but I really would have LOVED a
big fat warning in the release notes that a) everything with the version code
was kinda-broken before, and b) that one really needs to review the config.xml
now before updating.
> platforms/android/build.gradle modifies android versionCode
> -----------------------------------------------------------
>
> Key: CB-8976
> URL: https://issues.apache.org/jira/browse/CB-8976
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Environment: Android
> Reporter: zack dykes
> Assignee: Joe Bowser
> Priority: Minor
>
> cordova 5.0.0
> platforms/android/build.gradle modifies android versionCode at ln 178
> as I understand it max size for versionCode is (2^31)-1
> http://stackoverflow.com/a/24246191/126600
> in my config.xml:
> {code}
> android-versionCode="1385039613"
> {code}
> when I run {{cordova build android}}, I get:
> {code}
> FAILURE: Build failed with an exception.
> * Where:
> Build file
> '/Users/zackd/dev/code/cordova/cordova-ansr-fat-client/ondeviceresearch/platforms/android/build.gradle'
> line: 178
> * What went wrong:
> A problem occurred evaluating root project 'android'.
> > For input string: "13850396130"
> {code}
> and build.gradle, ln 178
> {code}
> versionCode cdvVersionCode ?: Integer.parseInt("" +
> privateHelpers.extractIntFromManifest("versionCode") + "0")
> {code}
> looks like this is appending "0" to my versionCode, producing 13850396130
> which is larger than max size for android versionCode
> if I mod ln 178 as follows, build succeeds
> {code}
> versionCode cdvVersionCode ?: Integer.parseInt("" +
> privateHelpers.extractIntFromManifest("versionCode"))
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
