[
https://issues.apache.org/jira/browse/CB-10974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15689850#comment-15689850
]
ASF GitHub Bot commented on CB-10974:
-------------------------------------
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/169
CB-10974 Cordova file transfer Content-Length header problem
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
Don't force chunkedMode=true for HTTPS if it was specified as false in the
UploadOptions (added a warning about possible OOM for chunkedMode=false+HTTPS
case)
### What testing has been done on this change?
Manual and auto tests
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daserge/cordova-plugin-file-transfer CB-10974
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file-transfer/pull/169.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #169
----
commit 655489905ab5bd2600d4eaf80e8dd5d27e96b461
Author: daserge <[email protected]>
Date: 2016-11-23T11:33:32Z
CB-10974 Cordova file transfer Content-Length header problem
Don't force chunkedMode=true for HTTPS if it was specified as false in the
UploadOptions (added a warning about possible OOM for chunkedMode=false+HTTPS
case)
----
> Cordova file transfer Content-Length header problem
> ---------------------------------------------------
>
> Key: CB-10974
> URL: https://issues.apache.org/jira/browse/CB-10974
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
> Environment: iPad Mini 2 with iOS 9.3
> Reporter: Roman Lapotchkin
> Assignee: Sergey Shakhnazarov
> Labels: iOS, triaged
>
> The Content-Length header always sending even options.chunkedMode is true. It
> expected header Transfer-Encoding: chuncked. When i commented this code in
> src/ios/CDVFileTransfer.m at line 232 it works:
> [req setValue:[[NSNumber numberWithLongLong:totalPayloadLength] stringValue]
> forHTTPHeaderField:@"Content-Length"];
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
